imbajin commented on code in PR #154:
URL:
https://github.com/apache/incubator-hugegraph-ai/pull/154#discussion_r1906915619
##########
hugegraph-llm/src/hugegraph_llm/operators/index_op/semantic_id_query.py:
##########
@@ -33,15 +33,13 @@ def __init__(
self,
embedding: BaseEmbedding,
by: Literal["query", "keywords"] = "keywords",
- topk_per_query: int = 10,
- topk_per_keyword: int = 1
Review Comment:
we should better keep the params to let other devs could use functions
directly
##########
hugegraph-llm/src/hugegraph_llm/operators/index_op/semantic_id_query.py:
##########
@@ -33,15 +33,13 @@ def __init__(
self,
embedding: BaseEmbedding,
by: Literal["query", "keywords"] = "keywords",
- topk_per_query: int = 10,
- topk_per_keyword: int = 1
Review Comment:
we should better keep the params to let other devs use functions directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
