imbajin commented on code in PR #149:
URL:
https://github.com/apache/incubator-hugegraph-ai/pull/149#discussion_r1913071540
##########
.licenserc.yaml:
##########
@@ -80,6 +80,7 @@ header: # `header` section is configurations for source codes
license header.
- '**/META-INF/MANIFEST.MF'
- '.repository/**'
- '**/resources/**'
+ - '**/poetry.lock' # this is for poetry lock config
Review Comment:
```suggestion
- '**/poetry.lock'
```
##########
.github/workflows/check-dependencies.yml:
##########
@@ -22,6 +22,7 @@ jobs:
# Action will fail if dependencies don't match the list (we could
choose only one of the following)
deny-licenses: GPL-3.0, AGPL-1.0, AGPL-3.0, LGPL-2.0, CC-BY-3.0
#allow-licenses: Apache-2.0, MIT
+
Review Comment:
```suggestion
```
##########
hugegraph-llm/README.md:
##########
@@ -17,8 +17,9 @@ graph systems and large language models.
## 2. Environment Requirements
-- python 3.9+ (better to use `3.10`)
+- python 3.10+(Gradio 5 requires Python 3.10 or higher)
Review Comment:
```suggestion
- python 3.10+ (not tested in 3.12)
```
##########
hugegraph-llm/README.md:
##########
@@ -17,8 +17,9 @@ graph systems and large language models.
## 2. Environment Requirements
-- python 3.9+ (better to use `3.10`)
+- python 3.10+(Gradio 5 requires Python 3.10 or higher)
- hugegraph-server 1.3+
Review Comment:
```suggestion
- hugegraph-server 1.3+ (better to use 1.5+)
```
##########
hugegraph-llm/requirements.txt:
##########
@@ -15,4 +15,4 @@ pyarrow~=17.0.0 # TODO: a temporary dependency for pandas,
figure out why Import
pandas~=2.2.2
openpyxl~=3.1.5
pydantic-settings~=2.6.1
-apscheduler~=3.10.4
+apscheduler~=3.10.4
Review Comment:
```suggestion
apscheduler~=3.10.4
```
##########
.github/workflows/check-dependencies.yml:
##########
@@ -2,7 +2,7 @@ name: "License header & 3rd-party check"
on:
pull_request:
-
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
