chiruu12 commented on PR #179:
URL: 
https://github.com/apache/incubator-hugegraph-ai/pull/179#issuecomment-2705546278

   > > > @imbajin Sir please check the pr and let me know if there is any 
changes that I need to make
   > > 
   > > 
   > > Fine, we add a separate `async_streaming_generate` in the latest 
change/commit, seems we could use it to provide the aysnc_streaming api?
   > > refer
   > > 
https://github.com/apache/incubator-hugegraph-ai/blob/7ae5d6fcc1013bc39164672355a8270f078bff8d/hugegraph-llm/src/hugegraph_llm/models/llms/base.py#L51
   > > 
   > > PS: Remember pull code first~
   > 
   > @chiruu12 Also note the `stream_http_api` is also not bounded to gradio, 
and it seems that the design may need to be improved. (and remember to use 
`agenerate_streaming()` function if we can)
   > 
   > And it's better to follow the design of LLM such as `OpenAI` to provide a 
`stream` parameter instead of adding a separate API path. The internal logic 
can be implemented separately in two functions to provide a unified interface 
for the user layer
   
   understood sir I will try to get this done as soon as my exams are over and 
then maybe we can work on the other issue too!
   Also had made an elementary demo for the agent. Let me know if you will get 
some time to review it too.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@hugegraph.apache.org
For additional commands, e-mail: issues-h...@hugegraph.apache.org

Reply via email to