imbajin commented on code in PR #188:
URL:
https://github.com/apache/incubator-hugegraph-ai/pull/188#discussion_r2022408001
##########
hugegraph-llm/src/hugegraph_llm/demo/rag_demo/rag_block.py:
##########
@@ -145,7 +145,6 @@ def update_ui_configs(
graph_search = graph_only_answer or graph_vector_answer
return graph_search, gremlin_prompt, vector_search
-
Review Comment:
Is it as expected?
##########
hugegraph-llm/src/hugegraph_llm/utils/decorators.py:
##########
@@ -90,3 +90,20 @@ def wrapper(*args: Any, **kwargs: Any) -> Any:
log.debug("%s QPS: %f/s", args[0].__class__.__name__, qps)
return result
return wrapper
+
+def with_task_id(func: Callable) -> Callable:
+ def wrapper(*args: Any, **kwargs: Any) -> Any:
+ import uuid
+ task_id = f"task_{str(uuid.uuid4())[:8]}"
+ log.info("New task created with id: %s", task_id)
Review Comment:
if we don't need to notify the users, maybe we should use `log.debug`?
##########
hugegraph-llm/src/hugegraph_llm/demo/rag_demo/rag_block.py:
##########
@@ -307,7 +307,7 @@ def toggle_slider(enable):
label="Query related information(Optional)",
)
btn = gr.Button("Answer Question", variant="primary")
-
+
Review Comment:
extra space?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
