Copilot commented on code in PR #666:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/666#discussion_r2108989945
##########
hugegraph-loader/src/main/java/org/apache/hugegraph/loader/executor/LoadOptions.java:
##########
@@ -255,6 +256,16 @@ public static LoadOptions parseOptions(String[] args) {
.addObject(options)
.build();
commander.parse(args);
+ try {
+ commander.parse(args);
+ // Check param < 3 (required minimum num)
+ if (args.length < 3) {
Review Comment:
[nitpick] The magic number `3` for minimum arguments is unclear. Define a
named constant or derive the required count programmatically to improve
readability and maintainability.
```suggestion
// Check if the number of arguments is less than the required
minimum
if (args.length < MINIMUM_REQUIRED_ARGS) {
```
##########
hugegraph-loader/src/main/java/org/apache/hugegraph/loader/executor/LoadOptions.java:
##########
@@ -255,6 +256,16 @@ public static LoadOptions parseOptions(String[] args) {
.addObject(options)
.build();
commander.parse(args);
Review Comment:
The code calls `commander.parse(args)` before and inside the try block,
causing redundant parsing. Consolidate to a single parse invocation within the
try-catch to avoid duplicate processing or unexpected exceptions.
```suggestion
```
##########
hugegraph-loader/src/main/java/org/apache/hugegraph/loader/executor/LoadOptions.java:
##########
@@ -201,8 +203,7 @@ public class LoadOptions implements Serializable {
description = "Whether the hugegraph-loader work in test mode")
public boolean testMode = false;
- @Parameter(names = {"--help"}, help = true,
- description = "Print usage of HugeGraphLoader")
+ @Parameter(names = {"-help", "--help"}, help = true, description = "Print
usage of HugeGraphLoader")
Review Comment:
[nitpick] Using `-help` as a single-dash long option is unconventional and
may conflict with other flags. Consider following standard CLI conventions
(e.g., `-h` or `-?` for help) or documenting this choice clearly.
```suggestion
@Parameter(names = {"-h", "--help"}, help = true, description = "Print
usage of HugeGraphLoader")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@hugegraph.apache.org
For additional commands, e-mail: issues-h...@hugegraph.apache.org
