Copilot commented on code in PR #2789:
URL:
https://github.com/apache/incubator-hugegraph/pull/2789#discussion_r2137082633
##########
.github/workflows/server-ci.yml:
##########
@@ -70,6 +66,15 @@ jobs:
run: |
mvn clean compile -U -Dmaven.javadoc.skip=true -ntp
+ - name: Package (for hstore)
+ if: ${{ matrix.BACKEND == 'hstore' }}
+ run: |
+ mvn package -U -Dmaven.javadoc.skip=true -Dmaven.test.skip=true -ntp
+
+ - name: Prepare backend unique environment
+ run: |
+ bash ../scripts/prepare-backend.sh $BACKEND
Review Comment:
The relative path `../scripts/prepare-backend.sh` is incorrect from the repo
root. Update it to `.github/scripts/prepare-backend.sh` (or use `${{
github.workspace }}/.github/scripts/prepare-backend.sh`) so the script can be
found.
```suggestion
bash .github/scripts/prepare-backend.sh $BACKEND
```
##########
.github/scripts/prepare-backend.sh:
##########
@@ -0,0 +1,13 @@
+#!/bin/bash
+set -e
+
+BACKEND=$1
+
+echo "Preparing backend ci environment for $BACKEND..."
+
+if [[ "$BACKEND" == "hstore" ]]; then
+ mvn package -U -Dmaven.javadoc.skip=true -Dmaven.test.skip=true -ntp
Review Comment:
[nitpick] Packaging is already handled in the CI workflow step; consider
removing this duplicate `mvn package` call to streamline the script.
```suggestion
# Packaging is handled in the CI workflow; removed redundant mvn package
call.
```
##########
.github/workflows/server-ci.yml:
##########
@@ -70,6 +66,15 @@ jobs:
run: |
mvn clean compile -U -Dmaven.javadoc.skip=true -ntp
+ - name: Package (for hstore)
+ if: ${{ matrix.BACKEND == 'hstore' }}
+ run: |
+ mvn package -U -Dmaven.javadoc.skip=true -Dmaven.test.skip=true -ntp
+
Review Comment:
This packaging step for the `hstore` backend is duplicated later in
`prepare-backend.sh`. Removing one of these calls will speed up the CI run and
avoid redundant work.
```suggestion
# Removed redundant 'Package (for hstore)' step as it is handled in
prepare-backend.sh
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
