VGalaxies commented on code in PR #2797: URL: https://github.com/apache/incubator-hugegraph/pull/2797#discussion_r2149149104
########## hugegraph-server/hugegraph-dist/src/assembly/travis/start-pd.sh: ########## @@ -18,7 +18,16 @@ set -ev HOME_DIR=$(pwd) -PD_DIR=$HOME_DIR/hugegraph-pd/apache-hugegraph-pd-incubating-1.5.0 + +PROPERTIES_FILE="$HOME_DIR/hugegraph-commons/hugegraph-common/src/main/resources/version.properties" Review Comment: By referencing the `version.properties` file in `hugegraph-commons` using a relative path, considering that `start-pd.sh` an `start-store.sh` are currently only used in the CI environment, maybe acceptable for now... @imbajin What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
