imbajin commented on PR #2797:
URL:
https://github.com/apache/incubator-hugegraph/pull/2797#issuecomment-3004471842
> > @koi2000 I would like to confirm if we upgrade the version of hugegraph
to 1.9, we need to modify the following files:
> > ```diff
> > diff --git
a/hugegraph-commons/hugegraph-common/src/main/resources/version.properties
b/hugegraph-commons/hugegraph-common/src/main/resources/version.properties
> > index b413bf04e..1ef0cba5a 100644
> > ---
a/hugegraph-commons/hugegraph-common/src/main/resources/version.properties
> > +++
b/hugegraph-commons/hugegraph-common/src/main/resources/version.properties
> > @@ -19,5 +19,5 @@
> > Version=${revision}
> > ApiVersion=0.71
> > ApiCheckBeginVersion=1.0
> > -ApiCheckEndVersion=1.7
> > -VersionInBash=1.5.0
> > +ApiCheckEndVersion=2.0
> > +VersionInBash=1.9.0
> > diff --git a/hugegraph-commons/pom.xml b/hugegraph-commons/pom.xml
> > index 09cd71e5a..df3337dd1 100644
> > --- a/hugegraph-commons/pom.xml
> > +++ b/hugegraph-commons/pom.xml
> > @@ -90,7 +90,7 @@
> >
> > <properties>
> > <!-- Note: We need also update the version in
CommonVersion.java & RpcVersion.java now -->
> > - <revision>1.5.0</revision>
> > + <revision>1.9.0</revision>
> >
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
> > <top.level.dir>${project.basedir}/..</top.level.dir>
> > <compiler.source>1.8</compiler.source>
> > diff --git a/pom.xml b/pom.xml
> > index 1fa07660e..fa98ec7a4 100644
> > --- a/pom.xml
> > +++ b/pom.xml
> > @@ -86,8 +86,8 @@
> > </scm>
> >
> > <properties>
> > - <revision>1.5.0</revision>
> > - <hugegraph-commons.version>1.5.0</hugegraph-commons.version>
> > + <revision>1.9.0</revision>
> > + <hugegraph-commons.version>1.9.0</hugegraph-commons.version>
> > <lombok.version>1.18.30</lombok.version>
> > <release.name>hugegraph</release.name>
> > <maven.compiler.source>11</maven.compiler.source>
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > if this aligns with the design expectations?
>
> You may also need to update the revision in the pom file under
hugegraph-commons, or use a command similar to the following during the build:
mvn package -DskipTests -Drevision=1.9.0 -ntp
>
> In terms of design, I have only removed the hard-coded version information
in the code. Perhaps it would be worth trying to move all version information
into the POM file in the root directory for management. However, I have not
found a suitable solution, as the fields in the compiled version.properties
file cannot be read by start-pd.sh and start-store.sh. Therefore, the
VersionInBash hard-coded value has been retained in version.properties. Should
I modify the current solution?
@koi2000 maybe we need add a basic doc for it? (How could other devs modify
the version if they need)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
