Copilot commented on code in PR #287:
URL:
https://github.com/apache/incubator-hugegraph-ai/pull/287#discussion_r2218602501
##########
vermeer-python-client/pyproject.toml:
##########
@@ -17,37 +17,43 @@
[project]
name = "vermeer-python-client"
-version = "1.5.0"
-description = "A Python SDK for Apache Vermeer."
+version = "1.5.0" # Independently managed version for the
vermeer-python-client package
+description = "A Python client library for interacting with Vermeer, a tool
for managing and analyzing large-scale graph data."
authors = [
- { name = "Apache HugeGraph Contributors", email =
"[email protected]" },
+ { name = "Apache HugeGraph Contributors", email =
"[email protected]" }
]
readme = "README.md"
-license = "Apache-2.0"
+license = "Apache-2.0" # Assuming Apache-2.0, consistent with others
Review Comment:
The comment 'Assuming Apache-2.0' suggests uncertainty about the license.
Either verify and remove the comment, or properly research the correct license
for this module.
```suggestion
license = "Apache-2.0"
```
##########
vermeer-python-client/pyproject.toml:
##########
@@ -17,37 +17,43 @@
[project]
name = "vermeer-python-client"
-version = "1.5.0"
-description = "A Python SDK for Apache Vermeer."
+version = "1.5.0" # Independently managed version for the
vermeer-python-client package
+description = "A Python client library for interacting with Vermeer, a tool
for managing and analyzing large-scale graph data."
authors = [
- { name = "Apache HugeGraph Contributors", email =
"[email protected]" },
+ { name = "Apache HugeGraph Contributors", email =
"[email protected]" }
]
readme = "README.md"
-license = "Apache-2.0"
+license = "Apache-2.0" # Assuming Apache-2.0, consistent with others
requires-python = ">=3.9"
+
dependencies = [
- "decorator~=5.1.1",
- "requests~=2.32.0",
- "urllib3~=2.2.2",
+ # Common dependencies
+ "decorator",
+ "requests",
+ "setuptools",
+ "urllib3",
+ "rich",
+
+ # Vermeer specific dependencies
+ "python-dateutil",
]
[project.urls]
-"Homepage" = "https://github.com/apache/incubator-hugegraph-ai";
-"Repository" = "https://github.com/apache/incubator-hugegraph-ai";
-"Bug Tracker" = "https://github.com/apache/incubator-hugegraph-ai/issues";
-
-[project.optional-dependencies]
-dev = [
- "pytest>=7.0.0",
- "black>=23.0.0",
- "isort>=5.0.0",
- "flake8>=6.0.0",
-]
+homepage = "https://hugegraph.apache.org/"; # Placeholder, update if specific
URL exists
Review Comment:
The comment indicates this is a placeholder URL that needs updating. Either
update to the correct URL or remove the placeholder comment.
```suggestion
homepage = "https://hugegraph.apache.org/";
```
##########
vermeer-python-client/pyproject.toml:
##########
@@ -17,37 +17,43 @@
[project]
name = "vermeer-python-client"
-version = "1.5.0"
-description = "A Python SDK for Apache Vermeer."
+version = "1.5.0" # Independently managed version for the
vermeer-python-client package
Review Comment:
The comment about 'independently managed version' is misleading since this
appears to be part of a workspace where versions should be coordinated.
Consider clarifying the versioning strategy or removing the comment.
```suggestion
version = "1.5.0"
```
##########
docker/Dockerfile.nk:
##########
@@ -3,21 +3,23 @@ FROM python:3.10.16-bookworm AS builder
WORKDIR /build/
-# 1.1 Copy source code
-COPY hugegraph-python-client/ ./hugegraph-python-client/
-COPY hugegraph-llm/ ./hugegraph-llm/
+# Use uv instead of poetry for a more efficient, elegant, and unified py env
management```
Review Comment:
The comment has malformed markdown with triple backticks at the end. Should
be: '# Use uv instead of poetry for a more efficient, elegant, and unified py
env management'
```suggestion
# Use uv instead of poetry for a more efficient, elegant, and unified py env
management
```
##########
vermeer-python-client/pyproject.toml:
##########
@@ -17,37 +17,43 @@
[project]
name = "vermeer-python-client"
-version = "1.5.0"
-description = "A Python SDK for Apache Vermeer."
+version = "1.5.0" # Independently managed version for the
vermeer-python-client package
+description = "A Python client library for interacting with Vermeer, a tool
for managing and analyzing large-scale graph data."
authors = [
- { name = "Apache HugeGraph Contributors", email =
"[email protected]" },
+ { name = "Apache HugeGraph Contributors", email =
"[email protected]" }
]
readme = "README.md"
-license = "Apache-2.0"
+license = "Apache-2.0" # Assuming Apache-2.0, consistent with others
requires-python = ">=3.9"
+
dependencies = [
- "decorator~=5.1.1",
- "requests~=2.32.0",
- "urllib3~=2.2.2",
+ # Common dependencies
+ "decorator",
+ "requests",
+ "setuptools",
+ "urllib3",
+ "rich",
+
+ # Vermeer specific dependencies
+ "python-dateutil",
]
[project.urls]
-"Homepage" = "https://github.com/apache/incubator-hugegraph-ai";
-"Repository" = "https://github.com/apache/incubator-hugegraph-ai";
-"Bug Tracker" = "https://github.com/apache/incubator-hugegraph-ai/issues";
-
-[project.optional-dependencies]
-dev = [
- "pytest>=7.0.0",
- "black>=23.0.0",
- "isort>=5.0.0",
- "flake8>=6.0.0",
-]
+homepage = "https://hugegraph.apache.org/"; # Placeholder, update if specific
URL exists
+repository = "https://github.com/apache/incubator-hugegraph-ai"; # Placeholder
Review Comment:
The comment indicates this is a placeholder repository URL. Either verify
this is correct and remove the placeholder comment, or update to the
appropriate URL.
```suggestion
repository = "https://github.com/apache/incubator-hugegraph-ai";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
