javeme commented on code in PR #2861:
URL:
https://github.com/apache/incubator-hugegraph/pull/2861#discussion_r2328620335
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/backend/query/Query.java:
##########
@@ -180,7 +180,9 @@ public long offset() {
}
public void offset(long offset) {
- E.checkArgument(offset >= 0L, "Invalid offset %s", offset);
+ if (offset < 0L) {
Review Comment:
due to there is no a universal check condition, but adding methods for
various check conditions is not a good idea.
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/backend/query/Query.java:
##########
@@ -287,17 +293,27 @@ public long total() {
public long limit() {
if (this.capacity != NO_CAPACITY) {
Review Comment:
We only modify the high-frequency codes on the main path and keep the other
low-frequency codes in their original style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@hugegraph.apache.org
For additional commands, e-mail: issues-h...@hugegraph.apache.org
