imbajin commented on code in PR #302: URL: https://github.com/apache/incubator-hugegraph-ai/pull/302#discussion_r2444559237
########## hugegraph-llm/pyproject.toml: ########## @@ -17,7 +17,7 @@ [project] name = "hugegraph-llm" -version = "1.5.0" +version = "1.7.0" Review Comment: ⚠️ **Important: Version Bump Justification** The version jumps from 1.5.0 to 1.7.0 (skipping 1.6.0): ```python -version = "1.5.0" +version = "1.7.0" ``` For a refactoring PR, this is an unusual version jump. Could you clarify: 1. Why skip 1.6.0? 2. Does this follow semantic versioning conventions? 3. Are there breaking changes that warrant a minor version bump? Please document the versioning strategy for consistency. ########## README.md: ########## @@ -75,42 +75,6 @@ python -m hugegraph_llm.demo.rag_demo.app > [!NOTE] > Examples assume you've activated the virtual environment with `source > .venv/bin/activate` -#### GraphRAG - Question Answering - -```python -from hugegraph_llm.operators.graph_rag_task import RAGPipeline - -# Initialize RAG pipeline -graph_rag = RAGPipeline() - -# Ask questions about your graph -result = (graph_rag - .extract_keywords(text="Tell me about Al Pacino.") - .keywords_to_vid() - .query_graphdb(max_deep=2, max_graph_items=30) - .merge_dedup_rerank() - .synthesize_answer() - .run()) -``` - -#### Knowledge Graph Construction - -```python -from hugegraph_llm.models.llms.init_llm import LLMs -from hugegraph_llm.operators.kg_construction_task import KgBuilder - -# Build KG from text -TEXT = "Your text content here..." -builder = KgBuilder(LLMs().get_chat_llm()) - -(builder - .import_schema(from_hugegraph="hugegraph") - .chunk_split(TEXT) - .extract_info(extract_type="property_graph") - .commit_to_hugegraph() - .run()) -``` - #### Graph Machine Learning Review Comment: ⚠️ **Important: Documentation Removal Without Replacement** This PR removes important user-facing examples: - GraphRAG Question Answering example (lines 78-112) - Knowledge Graph Construction example These are valuable quick-start guides for users. If they're being removed due to the new workflow engine architecture: 1. Please provide updated examples that work with the new architecture 2. Or document why these patterns are deprecated 3. Consider adding migration guide for existing users Simply removing documentation without replacement creates a poor user experience. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
