imbajin commented on code in PR #683:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/683#discussion_r2444650890
##########
hugegraph-loader/src/main/java/org/apache/hugegraph/loader/HugeGraphLoader.java:
##########
@@ -233,15 +733,18 @@ private void loadStruct(InputStruct struct, InputReader
reader) {
ParseTaskBuilder taskBuilder = new ParseTaskBuilder(this.context,
struct);
final int batchSize = this.context.options().batchSize;
List<Line> lines = new ArrayList<>(batchSize);
Review Comment:
**Race Condition Risk**: `InputProgress` is modified from multiple async
threads via `markLoaded()` calls. While the PR mentions thread-safety
improvements with synchronized maps, ensure ALL access patterns including reads
are properly synchronized. Consider using `ConcurrentHashMap` or explicit
synchronization blocks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
