imbajin commented on code in PR #304: URL: https://github.com/apache/incubator-hugegraph-ai/pull/304#discussion_r2465612350
########## hugegraph-llm/src/hugegraph_llm/config/index_config.py: ########## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import os +from typing import Optional + +from .models import BaseConfig + + +class IndexConfig(BaseConfig): + """LLM settings""" + + qdrant_host: Optional[str] = os.environ.get("QDRANT_HOST", None) + qdrant_port: int = int(os.environ.get("QDRANT_PORT", "6333")) Review Comment: ‼️ **类型安全问题**: 这里使用了 `type: ignore[arg-type]`,但没有充分说明原因。`int(port)` 转换可能在 port 为 None 或空字符串时失败。 建议改进: ```python if port is not None and str(port).strip(): index_settings.milvus_port = int(port) else: # Use default or handle error raise ValueError("Port must be provided") ``` 这样可以避免类型检查器警告,并提供更明确的错误处理。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
