imbajin commented on code in PR #2906:
URL:
https://github.com/apache/incubator-hugegraph/pull/2906#discussion_r2545599267
##########
hugegraph-store/hg-store-core/pom.xml:
##########
@@ -178,6 +178,12 @@
<artifactId>hg-store-client</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.hugegraph</groupId>
+ <artifactId>hg-pd-core</artifactId>
Review Comment:
> 1. 目前hg-pd-core和hg-store-core之间没有循环依赖问题；
> 2.
对于RaftReflectionUtil的模块问题，之前排除了hugegraph-common（因为这样做需要给hugegraph-common引入过多依赖），并且hg-store-core和hg-pd-core没有共同依赖的模块，因此选择直接让hg-pd-core依赖hg-pd-core，暂时没有想到更好的实现。
> 3. 已修改为使用${revision}。
嗯嗯, 合理的, 另外 revision 应该是不需要声明的, 参考一下 server 的父子模块, 它默认会使用项目级别的版本号 (revision)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
