imbajin commented on code in PR #2919:
URL: 
https://github.com/apache/incubator-hugegraph/pull/2919#discussion_r2618211912


##########
hugegraph-pd/hg-pd-core/src/main/java/org/apache/hugegraph/pd/raft/RaftRpcClient.java:
##########
@@ -60,7 +60,7 @@ public synchronized boolean init(final RpcOptions rpcOptions) 
{
     private <V> void internalCallAsyncWithRpc(final Endpoint endpoint,
                                               final 
RaftRpcProcessor.BaseRequest request,
                                               final FutureClosureAdapter<V> 
closure) {
-        final InvokeContext invokeCtx = null;
+        final InvokeContext invokeCtx = new InvokeContext();
         final InvokeCallback invokeCallback = new InvokeCallback() {

Review Comment:
   Any context for it? And we should add some basic tests to ensure the logic 
right



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to