Copilot commented on code in PR #2918:
URL:
https://github.com/apache/incubator-hugegraph/pull/2918#discussion_r2626056467
##########
hugegraph-server/hugegraph-test/src/main/java/org/apache/hugegraph/unit/util/StringEncodingTest.java:
##########
@@ -180,4 +181,19 @@ public void testReadAsciiString() {
buf = Bytes.fromHex("80");
Assert.assertEquals("", StringEncoding.readAsciiString(buf, 0));
}
+
+ @Test
+ public void testCheckPasswordSupportsOldAndNewCost() {
+ // oldWorkFactor
+ String oldPassword = BCrypt.hashpw("123456", BCrypt.gensalt(4));
+ // newWorkFactor
+ String newPassword = BCrypt.hashpw("123456", BCrypt.gensalt(12));
+
+ Assert.assertTrue(StringEncoding.checkPassword("123456", oldPassword));
+ Assert.assertTrue(StringEncoding.checkPassword("123456", newPassword));
+
+ // 反向校验，确保不接受错误口令
Review Comment:
The comment '反向校验,确保不接受错误口令' is in Chinese. For consistency and
accessibility across the international development community, please translate
this comment to English.
```suggestion
// Reverse validation to ensure incorrect passwords are not accepted
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
