imbajin commented on code in PR #704:
URL: 
https://github.com/apache/incubator-hugegraph-toolchain/pull/704#discussion_r2702527987


##########
hugegraph-loader/src/main/java/org/apache/hugegraph/loader/HugeGraphLoader.java:
##########
@@ -662,24 +662,21 @@ private List<InputTaskItem> 
prepareTaskItems(List<InputStruct> structs,
     }
 
     private void loadStructs(List<InputStruct> structs) {
-        int parallelCount = this.context.options().parallelCount;
+        int parallelThreads = this.context.options().parallelThreads;

Review Comment:
   🧹 **代码清理建议**
   
   既然参数名已经从 `parallelCount` 重命名为 `parallelThreads`,相应的变量名也应该更新以保持一致性。
   
   ```suggestion
           int parallelThreads = this.context.options().parallelThreads;
           if (structs.size() == 0) {
               return;
           }
   ```
   
   而且 parallelThreads 是一个很模糊的命名, 应该考虑用 parseThreads 类似具体化
   
   这样可以避免变量名和配置字段名不一致带来的混淆。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to