bitflicker64 commented on issue #2942: URL: https://github.com/apache/incubator-hugegraph/issues/2942#issuecomment-3780672127
One corner case to watch out for: not all URL options should default to http://. For example server.k8s_url currently defaults to https://127.0.0.1:8888 and in real deployments K8S API often requires HTTPS + CA config. If we implement a generic “prepend http:// when scheme is missing” for all URL-like keys (anything containing url / urls), then a user config like: server.k8s_url=127.0.0.1:8888 would silently become http://127.0.0.1:8888, effectively downgrading the scheme and potentially breaking K8S integration. https://github.com/apache/incubator-hugegraph/blob/37be6cdde3a2ffb71091453b366f28ae446db882/hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/config/ServerOptions.java#L275-L282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
