imbajin commented on code in PR #2940:
URL:
https://github.com/apache/incubator-hugegraph/pull/2940#discussion_r2731178885
##########
hugegraph-server/hugegraph-test/src/main/java/org/apache/hugegraph/core/CoreTestSuite.java:
##########
@@ -26,7 +26,6 @@
import org.apache.hugegraph.testutil.Utils;
import org.apache.hugegraph.util.Log;
import org.junit.AfterClass;
-import org.junit.Assert;
Review Comment:
⚠️ **Important: Unused import after removing Assert.assertNotNull()**
The `Assert` import at line 29 is now unused since
`Assert.assertNotNull(graph)` was removed. The PR diff shows removing the
import at line 29, which is correct.
Please verify the build passes without checkstyle/import warnings.
##########
hugegraph-server/hugegraph-test/src/main/java/org/apache/hugegraph/core/CoreTestSuite.java:
##########
@@ -52,11 +51,18 @@
public class CoreTestSuite {
private static boolean registered = false;
- private static HugeGraph graph = null;
+ private static volatile HugeGraph graph = null;
Review Comment:
⚠️ **Important: Commented-out code should be removed or documented**
The commented-out line `//Assert.assertFalse(graph.closed());` was already
present before this PR. Consider either:
1. Removing it entirely if it's no longer needed
2. Adding a TODO comment explaining why it's commented out and when it
should be re-enabled
This helps maintain code clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
