bitflicker64 commented on PR #450: URL: https://github.com/apache/incubator-hugegraph-doc/pull/450#issuecomment-3870379128
> > fixed more links and also <img alt="image" width="650" height="90" src="https://private-user-images.githubusercontent.com/211528427/546990630-4ac373d8-362d-41be-af08-148b9313dced.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzA2Mjc1MTQsIm5iZiI6MTc3MDYyNzIxNCwicGF0aCI6Ii8yMTE1Mjg0MjcvNTQ2OTkwNjMwLTRhYzM3M2Q4LTM2MmQtNDFiZS1hZjA4LTE0OGI5MzEzZGNlZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwMjA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDIwOVQwODUzMzRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jYTVjOWRhNTRiNGI3NGUyNDk1MGY3ZDNlNmZlYmEyMTE2MDk0MDJmNGRkMTVkOGY4NTE0ZTZjN2M5ZTBkYzZiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.-Qg3qKDk5ZUPvVreewlVlB0euUWZvghKeIogf_fdiUo";> > > @bitflicker64 Glad it passed locally. However, the fact that CI passed previously with broken links shows the script is flawed. We should make the check stricter so that any 404 links result in a CI failure. > > https://github.com/apache/incubator-hugegraph-doc/blob/0d3b632c6894902e6afb6e5834c4a47c1df4baff/.github/workflows/hugo.yml#L44C33-L44C33 > > Refer: https://github.com/apache/incubator-hugegraph-doc/actions/runs/21623005341/job/62316158334 (Previous PR CI log) That makes sense - the validation script should definitely be catching these. For this PR, I've fixed the broken links I found. Should improving the validate-links.sh script be a separate issue/PR, or would you like me to include that here as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://private-user-images.githubusercontent.com/211528427/546990630-4ac373d8-362d-41be-af08-148b9313dced.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzA2Mjc1MTQsIm5iZiI6MTc3MDYyNzIxNCwicGF0aCI6Ii8yMTE1Mjg0MjcvNTQ2OTkwNjMwLTRhYzM3M2Q4LTM2MmQtNDFiZS1hZjA4LTE0OGI5MzEzZGNlZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwMjA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDIwOVQwODUzMzRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jYTVjOWRhNTRiNGI3NGUyNDk1MGY3ZDNlNmZlYmEyMTE2MDk0MDJmNGRkMTVkOGY4NTE0ZTZjN2M5ZTBkYzZiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.-Qg3qKDk5ZUPvVreewlVlB0euUWZvghKeIogf_fdiUo"](https://private-user-images.githubusercontent.com/211528427/546990630-4ac373d8-362d-41be-af08-148b9313dced.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzA2Mjc1MTQsIm5iZiI6MTc3MDYyNzIxNCwicGF0aCI6Ii8yMTE1Mjg0MjcvNTQ2OTkwNjMwLTRhYzM3M2Q4LTM2MmQtNDFiZS1hZjA4LTE0OGI5MzEzZGNlZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwMjA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDIwOVQwODUzMzRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jYTVjOWRhNTRiNGI3NGUyNDk1MGY3ZDNlNmZlYmEyMTE2MDk0MDJmNGRkMTVkOGY4NTE0ZTZjN2M5ZTBkYzZiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.-Qg3qKDk5ZUPvVreewlVlB0euUWZvghKeIogf_fdiUo"){kind=link}