bitflicker64 commented on issue #2951: URL: https://github.com/apache/incubator-hugegraph/issues/2951#issuecomment-3904594461
> Thanks for the detailed report. A quick note first: we are currently in the Lunar New Year holiday period (similar to Christmas/New Year for many maintainers), so response times may be a bit slower than usual. Thanks for your patience. > > Your diagnosis is valid and this is not an isolated incident. In fact, PR [#2529](https://github.com/apache/incubator-hugegraph/pull/2529) already had an “avoid host network” TODO, so is a known technical debt. The direction is clear and should be handled as a proper refactor rather than incremental patching. > > Also, please base the compose changes on the current master branch, not on old 1.5.0-era config files. Master already includes several recent fixes that affect practical usability (startup/config behavior), and continuing from older code can introduce avoidable drift. > > Recommended docker-compose refactor direction: > > 1. Move single-node compose to bridge networking by default and remove host networking, so behavior is consistent across Linux/macOS/Windows Docker Desktop. > 2. Separate bind vs advertise addresses: bind can stay at 0.0.0.0, but service discovery must use container-reachable names (for example `pd:8686`, `store:8500`). > 3. Explicitly set `hugegraph.pd.peers=pd:8686` on the server side to avoid localhost/127.0.0.1 fallback. > 4. Align healthcheck endpoints to avoid false positives where containers are healthy but the cluster is not usable. > 5. Keep the patch surface minimal; prefer small config overrides instead of copying full conf directories to reduce long-term maintenance cost. > 6. Validation could focus on Unix environments (primarily Linux + macOS) > > BTW, maybe we do need **a plan** for it first (before review PR [#2952](https://github.com/apache/incubator-hugegraph/pull/2952), to avoid large gaps) > > Also I'll share a CI(action) file for u to test it in your docker environment. Makes sense. Thanks for the clarification and detailed guidance. I will review the refactor direction and update my perspective based on the points you outlined. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
