Copilot commented on code in PR #2970: URL: https://github.com/apache/hugegraph/pull/2970#discussion_r2940394953
########## hugegraph-store/docs/operations-guide.md: ########## @@ -593,8 +593,9 @@ curl http://192.168.1.10:8620/v1/partitionsAndStatus 1. **Deploy New Store Node**: ```bash # Follow deployment guide - tar -xzf apache-hugegraph-store-1.7.0.tar.gz - cd apache-hugegraph-store-1.7.0 + # Historical 1.7.0 packages still include the "-incubating" suffix Review Comment: The note says 'Historical 1.7.0 packages', but elsewhere in this PR the rule is '1.7.0 and earlier'. To avoid inconsistency/misleading guidance, update this wording to explicitly say '1.7.0 and earlier' (or whatever the exact cutoff is). ########## hugegraph-store/README.md: ########## @@ -104,12 +104,12 @@ From the project root: mvn install -pl hugegraph-struct -am -DskipTests # Build Store and all dependencies -mvn clean package -pl hugegraph-store/hugegraph-store-dist -am -DskipTests +mvn clean package -pl hugegraph-store/hg-store-dist -am -DskipTests Review Comment: This PR is described as adding notes about historical package names, but it also changes the documented Maven module path from `hugegraph-store/hugegraph-store-dist` to `hugegraph-store/hg-store-dist`. If this is intentional, the PR description/title should be updated (or the change split into a separate PR) and the new module path should be verified to match the actual module name used in the repo. ########## hugegraph-store/docs/development-guide.md: ########## @@ -58,7 +58,7 @@ git checkout 1.7-rebase 2. Add new "Application" configuration: - Main class: `org.apache.hugegraph.store.node.StoreNodeApplication` - VM options: `-Xms4g -Xmx4g -Dconfig.file=conf/application.yml` - - Working directory: `hugegraph-store/apache-hugegraph-store-1.7.0` + - Working directory: `hugegraph-store/apache-hugegraph-store-<version>` (`apache-hugegraph-store-incubating-<version>` for historical 1.7.0 and earlier directories) Review Comment: This introduces the `<version>` placeholder style, while other docs in this PR (e.g., root README and hugegraph-store/README) use `{version}`/`{version}`-style placeholders. Consider standardizing on a single placeholder convention across the docs touched in this PR to reduce reader confusion. ########## README.md: ########## @@ -223,9 +223,17 @@ Download pre-built packages from the [Download Page](https://hugegraph.apache.or ```bash # Download and extract -wget https://downloads.apache.org/hugegraph/{version}/apache-hugegraph-{version}.tar.gz -tar -xzf apache-hugegraph-{version}.tar.gz -cd apache-hugegraph-{version} +# For historical 1.7.0 and earlier releases, use the archive URL and +# set PACKAGE=apache-hugegraph-incubating-{version} instead. +BASE_URL="https://downloads.apache.org/hugegraph/{version}"; +PACKAGE="apache-hugegraph-{version}" +# Historical alternative: +# BASE_URL="https://archive.apache.org/dist/incubator/hugegraph/{version}"; +# PACKAGE="apache-hugegraph-incubating-{version}" + +wget ${BASE_URL}/${PACKAGE}.tar.gz +tar -xzf ${PACKAGE}.tar.gz +cd ${PACKAGE} Review Comment: In shell examples, unquoted variables can break when values contain characters like spaces (or globbing characters). Even though these examples likely won't include spaces, quoting is the safer documented pattern: `wget \"${BASE_URL}/${PACKAGE}.tar.gz\"`, `tar -xzf \"${PACKAGE}.tar.gz\"`, `cd \"${PACKAGE}\"`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
