contrueCT commented on PR #2972:
URL: https://github.com/apache/hugegraph/pull/2972#issuecomment-4111025992
> Thanks for the update. I left two small review comments; CI looks green on
my side, but I think these are still worth addressing.
> ⚠️ The busy-load branch is rate-limited, but this low-memory WARN will
still fire on every rejected request. Under sustained memory pressure that can
flood the logs and add more I/O pressure to an already stressed server. Please
apply the same REJECT_LOG_RATE_LIMITER here, or route both rejection logs
through a shared sampling helper.
> ⚠️ This test drives the real System.gc() path by forcing the low-memory
branch. That makes the suite slower and can make it behave differently on
constrained CI nodes or JVMs with different GC ergonomics. Consider adding a
test seam for the GC step so the test can stub it and only verify the rejection
behavior.
Changes made:
- Applied the same reject-log rate limiting to the low-memory branch, and
routed both rejection paths through a shared warning helper so the sampling
behavior is consistent.
- Added a small test seam for `gcIfNeeded()` / reject-log sampling so the
unit test no longer depends on a real `System.gc()` call.
- Expanded `LoadDetectFilterTest` to verify:
- busy rejection emits a warning log
- low-memory rejection emits a warning log
- whitelist / healthy paths do not emit rejection logs
- reject-log sampling suppresses repeated warning logs as expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
