contrueCT opened a new pull request, #2990:
URL: https://github.com/apache/hugegraph/pull/2990
<!--
Thank you very much for contributing to Apache HugeGraph, we are happy
that you want to help us improve it!
Here are some tips for you:
1. If this is your first time, please read the [contributing
guidelines](https://github.com/apache/hugegraph/blob/master/CONTRIBUTING.md)
2. If a PR fix/close an issue, type the message "close xxx" (xxx is the
link of related
issue) in the content, GitHub will auto link it (Required)
3. Name the PR title in "Google Commit Format", start with "feat | fix |
perf | refactor | doc | chore",
such like: "feat(core): support the PageRank algorithm" or "fix: wrong
break in the compute loop" (module is optional)
skip it if you are unsure about which is the best component.
4. One PR address one issue, better not to mix up multiple issues.
5. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` (or click
it directly after
published)
-->
## Purpose of the PR
- fix #2933 <!-- or use "fix #xxx", "xxx" is the ID-link of related issue,
e.g: close #1024 -->
<!--
Please explain more context in this section, clarify why the changes are
needed.
e.g:
- If you propose a new API, clarify the use case for a new API.
- If you fix a bug, you can clarify why it is a bug, and should be
associated with an issue.
-->
HugeGraph may read `LABEL` from `ConditionQuery` before the query is
flattened when optimizing edge traversals. For contradictory label conditions
such as:
```gremlin
g.V().inE("created").hasLabel("created", "look").hasLabel("authored")
```
the previous intersection logic used an empty set to mean both "not
initialized yet" and "already intersected to empty". As a result, a later IN
condition could repopulate the candidate labels and trigger:
Illegal key 'LABEL' with more than one value
instead of returning an empty result.
## Main Changes
Update ConditionQuery.condition(Object key) to track whether the
intersection has been initialized independently.
This keeps an empty intersection empty, so conflicting label predicates now
fall back safely and produce no matches, while the existing protection for true
multi-value results is preserved.
<!-- Please clarify what changes you are proposing. The purpose of this
section is to outline the changes and how this PR fixes the issue. These change
logs are helpful for better and faster reviews.)
For example:
- If you introduce a new feature, please show detailed design here or add
the link of design documentation.
- If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
- If there is a discussion in the mailing list, please add the link. -->
## Verifying these changes
Added regression coverage for both the low-level query behavior and the
traversal scenario from the issue:
QueryTest#testConditionWithEqAndIn
QueryTest#testConditionWithConflictingEqAndIn
EdgeCoreTest#testQueryInEdgesOfVertexByConflictingLabels
The edge traversal test also compares the direct traversal with an
equivalent match()-based query and verifies that both return 0 instead of
throwing an exception.
<!-- Please pick the proper options below -->
- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
- [ ] Already covered by existing tests, such as *(please modify tests
here)*.
- [x] Need tests and can be verified as follows:
- mvn -pl hugegraph-server/hugegraph-test -am -P core-test,memory
-DfailIfNoTests=false
-Dtest='QueryTest#testConditionWithEqAndIn+testConditionWithConflictingEqAndIn'
test
- mvn -pl hugegraph-server/hugegraph-test -am -P core-test,memory
-DfailIfNoTests=false
-Dtest='EdgeCoreTest#testQueryInEdgesOfVertexByConflictingLabels' test
## Does this PR potentially affect the following parts?
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] Dependencies ([add/update
license](https://hugegraph.apache.org/docs/contribution-guidelines/contribute/#321-check-licenses)
info &
[regenerate_known_dependencies.sh](../install-dist/scripts/dependency/regenerate_known_dependencies.sh))
<!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both
in root & dist module) -->
- [ ] Modify configurations
- [ ] The public API
- [ ] Other affects (typed here)
- [x] Nope
## Documentation Status
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `Doc - TODO` <!-- Your PR changes impact docs and you will update
later -->
- [ ] `Doc - Done` <!-- Related docs have been already added or updated -->
- [x] `Doc - No Need` <!-- Your PR changes don't impact/need docs -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
