peakxy opened a new pull request, #728:
URL: https://github.com/apache/hugegraph-toolchain/pull/728
<!--
Thank you very much for contributing to Apache HugeGraph, we are happy
that you want to help us improve it!
Here are some tips for you:
1. If this is your first time, please read the [contributing
guidelines](https://github.com/apache/hugegraph/blob/master/CONTRIBUTING.md)
2. If a PR fix/close an issue, type the message "close xxx" (xxx is the
link of related
issue) in the content, GitHub will auto link it (Required)
3. Name the PR title in "Google Commit Format", start with "feat | fix |
perf | refactor | doc | chore",
such like: "feat(core): support the PageRank algorithm" or "fix: wrong
break in the compute loop" (module is optional)
skip it if you are unsure about which is the best component.
4. One PR address one issue, better not to mix up multiple issues.
5. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` (or click
it directly after
published)
-->
## Purpose of the PR
This PR migrates the current repository-local CI jobs in
`apache/hugegraph-toolchain` to shared reusable workflows hosted in
`hugegraph/actions`.
The goal is to reduce duplicated GitHub Actions logic across modules while
keeping each module's trigger policy, path filters, compile commands, prepare
commands, and test commands unchanged.
## Main Changes
- Replace the inline CI job definitions in these workflows with thin
wrappers:
- `client-ci.yml`
- `client-go-ci.yml`
- `loader-ci.yml`
- `hubble-ci.yml`
- `tools-ci.yml`
- `spark-connector-ci.yml`
- Route Java-based modules to
`hugegraph/actions/.github/workflows/_toolchain_java_ci_reusable.yml@master`.
- Route `hugegraph-client-go` to
`hugegraph/actions/.github/workflows/_toolchain_go_ci_reusable.yml@master`.
- Keep the module-specific compile / prepare / test commands aligned with the
previous workflows, including the existing HugeGraph commit ids and
coverage
upload behavior.
- Preserve caller-owned staged Maven settings by continuing to read
`.github/configs/settings.xml` from the `hugegraph-toolchain` repository.
- Replace the invalid branch regex literal `/^release-.*$/` with the
supported
GitHub Actions glob `release-*`.
## Verifying these changes
- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
- [ ] Already covered by existing tests, such as *(please modify tests
here)*.
- [x] Need tests and can be verified as follows:
- In a fork, temporarily point the wrappers to
`peakxy/hugegraph-actions@<feature-branch>` for integration testing.
- Manually trigger `client-ci` and confirm the reusable Java workflow
keeps
the original compile and test sequence.
- Manually trigger `client-go-ci` and confirm the reusable Go workflow
keeps
the original HugeGraph environment preparation and `make test` flow.
- Manually trigger `loader-ci` and `hubble-ci` to verify the more complex
prepare steps still work with the reusable workflow inputs.
- Push to a `release-*` branch and confirm the workflow trigger works
with
the updated branch filter.
- Confirm `settings.xml` is still read from
`.github/configs/settings.xml` in the caller repository.
## Does this PR potentially affect the following parts?
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] Nope
- [ ] Dependencies (add/update license info) <!-- Don't forget to
add/update the info in "LICENSE" & "NOTICE" files (both in root & dist module)
-->
- [x] Modify configurations
- [ ] The public API
- [x] Other affects (GitHub Actions workflow structure for Toolchain CI)
## Documentation Status
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `Doc - TODO` <!-- Your PR changes impact docs and you will update
later -->
- [ ] `Doc - Done` <!-- Related docs have been already added or updated -->
- [x] `Doc - No Need` <!-- Your PR changes don't impact/need docs -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
