Copilot commented on code in PR #3010:
URL: https://github.com/apache/hugegraph/pull/3010#discussion_r3187110798
##########
.github/workflows/rerun-ci.yml:
##########
@@ -18,6 +18,7 @@ env:
jobs:
decide-rerun-action:
+ if: ${{ github.event.workflow_run.conclusion == 'failure' }}
Review Comment:
Adding a job-level `if` here only skips the job after the `workflow_run`
event has already started this workflow. GitHub will still create a `Rerun CI`
run for successful upstream workflows, so this change doesn't actually
eliminate the extra skipped rerun workflow records described in the PR.
##########
.github/workflows/server-ci.yml:
##########
@@ -100,3 +100,76 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}
file: ${{ env.REPORT_DIR }}/*.xml
+
+ build-server-macos-rocksdb:
+ runs-on: ${{ matrix.os }}
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - os: macos-15-intel
+ server_java_options: ''
+ - os: macos-15
+ server_java_options: '-Xms512m -Xmx2g'
+ env:
+ USE_STAGE: 'false' # Whether to include the stage repository.
+ TRAVIS_DIR: hugegraph-server/hugegraph-dist/src/assembly/travis
+ REPORT_DIR: target/site/jacoco
+ BACKEND: rocksdb
+ JAVA_VERSION: '11'
+ SERVER_JAVA_OPTIONS: ${{ matrix.server_java_options }}
+
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v4
+ with:
+ fetch-depth: 5
+
+ - name: Install Java ${{ env.JAVA_VERSION }}
+ uses: actions/setup-java@v4
+ with:
+ java-version: ${{ env.JAVA_VERSION }}
+ distribution: 'zulu'
+
+ - name: Cache Maven packages
+ uses: actions/cache@v4
+ with:
+ path: ~/.m2
+ key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
+ restore-keys: ${{ runner.os }}-m2
+
+ - name: Use staged maven repo settings
+ if: ${{ env.USE_STAGE == 'true' }}
+ run: |
+ cp $HOME/.m2/settings.xml /tmp/settings.xml
+ cp -vf .github/configs/settings.xml $HOME/.m2/settings.xml && cat
$HOME/.m2/settings.xml
+
+ - name: Compile
+ run: |
+ mvn clean compile -pl hugegraph-server/hugegraph-test -am -U
-Dmaven.javadoc.skip=true -ntp
+
+ - name: Run RocksDB core test
+ run: |
+ $TRAVIS_DIR/run-core-test.sh $BACKEND
+
+ - name: Run RocksDB API test
+ run: |
+ $TRAVIS_DIR/run-api-test.sh $BACKEND $REPORT_DIR
Review Comment:
This new job still calls `run-api-test.sh`, which generates a JaCoCo XML
report, but unlike the existing Linux job there is no follow-up upload step
here. As written, the macOS path is exercised, but its coverage never reaches
Codecov or any artifact, so the workflow doesn't actually add reported macOS
coverage.
##########
hugegraph-server/hugegraph-dist/src/assembly/travis/run-api-test.sh:
##########
@@ -21,7 +21,42 @@ BACKEND=$1
REPORT_DIR=$2
REPORT_FILE=$REPORT_DIR/jacoco-api-test-for-raft.xml
-TRAVIS_DIR=$(dirname $0)
+TRAVIS_DIR=$(cd "$(dirname "$0")" && pwd)
+REPO_ROOT=$(cd "$TRAVIS_DIR/../../../../.." && pwd)
Review Comment:
Making `TRAVIS_DIR` absolute here breaks the existing path logic in
`start-server.sh`, which still computes `JACOCO_DIR` as `${PWD}/${TRAVIS_DIR}`.
API-test runs with coverage enabled will now download/load `jacocoagent.jar`
from a nested `<repo>/<absolute-path>/...` location instead of the travis
directory, which is the wrong path and depends on creating extra directories
under the workspace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
