imbajin commented on PR #3025: URL: https://github.com/apache/hugegraph/pull/3025#issuecomment-4470902490
Yes, `**/target/dist/` can be removed since `**/target/` already covers it. For the archive patterns, I think it is fine to exclude local `*.tar.gz` / `*.tgz` / similar generated archives from the Docker build context. The Dockerfiles should rebuild the distribution packages inside the build stage, so the image build should not depend on pre-existing local release archives. The only thing I would like to confirm is validation: please make sure all four Docker images still build successfully and the new images can start normally after these ignore rules are applied. If that is verified, excluding these archive files sounds good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
