dpol1 commented on code in PR #3026: URL: https://github.com/apache/hugegraph/pull/3026#discussion_r3257972096
########## hugegraph-server/hugegraph-test/src/main/java/org/apache/hugegraph/unit/serializer/TextSerializerTest.java: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hugegraph.unit.serializer; + +import java.util.Date; + +import org.apache.hugegraph.backend.id.IdGenerator; +import org.apache.hugegraph.backend.serializer.TextSerializer; +import org.apache.hugegraph.backend.store.BackendEntry; +import org.apache.hugegraph.config.HugeConfig; +import org.apache.hugegraph.schema.PropertyKey; +import org.apache.hugegraph.schema.Userdata; +import org.apache.hugegraph.testutil.Assert; +import org.apache.hugegraph.unit.BaseUnitTest; +import org.apache.hugegraph.unit.FakeObjects; +import org.apache.hugegraph.util.DateUtil; +import org.junit.Test; + +public class TextSerializerTest extends BaseUnitTest { + + private static final String DATE_FORMAT = "yyyy-MM-dd HH:mm:ss.SSS"; + + @Test + public void testPropertyKeyUserdataCreateTimeRoundTripsAsDate() { + HugeConfig config = FakeObjects.newConfig(); + TextSerializer ser = new TextSerializer(config); + + FakeObjects objects = new FakeObjects(); + PropertyKey original = objects.newPropertyKey(IdGenerator.of(1L), + "name"); + Date created = DateUtil.parse("2026-05-14 10:11:12.345", DATE_FORMAT); + original.userdata(Userdata.CREATE_TIME, created); + + BackendEntry entry = ser.writePropertyKey(original); + PropertyKey reloaded = ser.readPropertyKey(objects.graph(), entry); + + Object value = reloaded.userdata().get(Userdata.CREATE_TIME); + Assert.assertTrue("CREATE_TIME should be a Date after round-trip, " + + "was " + (value == null ? "null" : value.getClass()), + value instanceof Date); + Assert.assertEquals(created, value); + } Review Comment: Holding off, with reasoning: `MysqlSerializer.readUserdata` (L167) and `CassandraSerializer.readUserdata` (L222) both call the same `schema.userdata(key, value)` setter as `TextSerializer`/`BinarySerializer`. That setter now routes through the single `Userdata.put` normalization path, which is already exercised by: - `TextSerializerTest` / `BinarySerializerTest` round-trips - `SchemaElementTest` (constructor, single setter, bulk, `fromMap`) There's no existing unit-test harness for the SQL serializers — adding one means backend/mock infra for **zero new code paths**. The marginal coverage doesn't justify it. Better closure for the shared logic: a direct `UserdataTest.normalizeValue` unit test, serializer-agnostic. Happy to add that as a follow-up; proposing not to gate this PR on it. Pushback welcome if you see a path difference I'm missing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
