BrandaoFelipe commented on PR #3029: URL: https://github.com/apache/hugegraph/pull/3029#issuecomment-4483132645
Hi @imbajin, Thank you for the detailed review. You raised several important concerns regarding runtime consistency, exception flow coverage, and backward compatibility of the public REST API contract. I agree that the current approach still leaves multiple competing exception-handling paths in place instead of establishing a single unified runtime contract. The points you raised are all valid and need to be addressed before this can be considered a proper unification. My current thinking is: **Server**: integrate the unified formatting into the existing ExceptionFilter infrastructure. **PD**: explore consolidating the existing controller-level catch-and-return patterns so exceptions can follow a consistent handling path. **Store**: preserve existing HgStoreException business codes in the response body while keeping HTTP status codes strictly for transport semantics. I also agree that the larger concern here is API compatibility. Since the current REST responses already expose module-specific response shapes and fields, introducing a new envelope format without a migration strategy could break downstream consumers. Before continuing implementation, I think we should first align on: - the target error response contract, - compatibility expectations, - migration/deprecation strategy, - and whether this should be treated as a breaking API change. Do you think it would be better to continue this discussion in the PR thread, or would this be more appropriate for a broader dev mailing list discussion first? Thanks again for the thoughtful review — this was very helpful in clarifying the architectural direction the PR should take. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
