vaijosh commented on PR #3022:
URL: https://github.com/apache/hugegraph/pull/3022#issuecomment-4494799514
> Thanks for the PR. I checked this locally on macOS arm64 and I think there
are two separate issues here.
>
> First, the README build-from-source path is indeed outdated. The actual
full distribution is produced as `target/apache-hugegraph-${version}.tar.gz`,
and the server scripts are under
`apache-hugegraph-${version}/apache-hugegraph-server-${version}/bin/`, not
directly under `install-dist/target/hugegraph-{version}`. This part should be
fixed as a documentation-only change and does not require adding a new
dependency.
>
> Second, the Apple Silicon Gremlin Console failure is real, but it is a
separate compatibility problem in the current TinkerPop 3.5.1 / JLine / Jansi
stack. Adding `jansi:2.4.0` may be a possible workaround, but it is not the
minimal fix for the README issue itself. If we want to claim that bundled
`bin/gremlin-console.sh` works on Apple Silicon, we should add a macOS arm64
smoke test that actually runs the console, for example on `macos-15`:
>
> ```shell
> VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout)
> SERVER_DIR="hugegraph-server/apache-hugegraph-server-${VERSION}"
> printf "println \"gremlin-console-smoke-ok\"\n" >
"$RUNNER_TEMP/gremlin-console-smoke.groovy"
> "${SERVER_DIR}/bin/gremlin-console.sh" -- -e
"$RUNNER_TEMP/gremlin-console-smoke.groovy"
> ```
>
> Also, we are preparing to upgrade TinkerPop to 3.8. Since the official
TinkerPop 3.8 Gremlin Console artifacts are already available and the current
TinkerPop download page lists Gremlin Console / Server compatibility with Java
11/17, I think we should first verify whether the TinkerPop 3.8 upgrade already
resolves the Jansi/JLine native-library issue before introducing a new direct
dependency here.
>
> So I would suggest splitting this PR:
>
> 1. README path correction only, no dependency change.
> 2. A separate Apple Silicon Gremlin Console compatibility fix, with macOS
arm64 CI coverage if we decide to support the bundled console before the
TinkerPop upgrade.
Hi @imbajin,
I have implemented the review comments. Separated the README.md changes from
mac m4 issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
