imbajin commented on code in PR #336:
URL: https://github.com/apache/hugegraph-ai/pull/336#discussion_r3279185350
##########
hugegraph-python-client/src/tests/api/test_gremlin.py:
##########
@@ -31,26 +32,24 @@ class TestGremlin(unittest.TestCase):
@classmethod
def setUpClass(cls):
+ # To run these tests locally, start HugeGraph via Docker:
+ # docker run -d -p 8080:8080 hugegraph/hugegraph:latest
+ #
+ # To explicitly skip Gremlin tests in CI or locally, set:
+ # SKIP_GREMLIN_TESTS=true
+ #
+ # Do NOT add automatic skip logic based on connectivity probes.
+ # Endpoint failures must surface as FAILED tests, not SKIPPED.
+ if os.environ.get("SKIP_GREMLIN_TESTS", "").lower() == "true":
Review Comment:
⚠️ Now that skipping is handled by raising `SkipTest` directly from
`setUpClass`, `skip_gremlin_tests` is no longer set to `True` anywhere. The
flag and the related `setUp()` / `tearDownClass()` branches are now dead code,
which makes the class look like it still has two skip mechanisms. Please remove
the flag and simplify the lifecycle so future changes only have one skip path
to reason about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
