WaterWhisperer commented on code in PR #3024: URL: https://github.com/apache/hugegraph/pull/3024#discussion_r3315242522
########## hugegraph-rocksdb-provider/src/main/java/org/apache/hugegraph/rocksdb/provider/AbstractRocksDBProvider.java: ########## @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hugegraph.rocksdb.provider; + +import org.rocksdb.*; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.List; + +/** + * Abstract base class for RocksDB providers that provides common utility methods. + * This class focuses only on the core abstraction of RocksDB open/close operations + * without complex configuration management. + */ +public abstract class AbstractRocksDBProvider implements RocksDBProvider { + + private static final Logger LOG = LoggerFactory.getLogger(AbstractRocksDBProvider.class); + + @Override + public final RocksDB openRocksDB(Options options, String dataPath) throws RocksDBException { + LOG.debug("Opening RocksDB with provider: {} at path: {}", getProviderName(), dataPath); + + // Initialize provider if needed + initialize(); + + try { + // Delegate to provider-specific implementation + RocksDB rocksDB = doOpenRocksDB(options, dataPath); + + return rocksDB; + } catch (Exception e) { + LOG.error("Failed to open RocksDB with provider: {} at path: {}", + getProviderName(), dataPath, e); + throw e; + } Review Comment: wrong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
