imbajin commented on code in PR #348:
URL:
https://github.com/apache/hugegraph-computer/pull/348#discussion_r3323910984
##########
vermeer/Makefile:
##########
@@ -66,20 +71,24 @@ clean-all: clean
@rm -rf tools/protoc/*/protoc
@rm -rf tools/protoc/*/bin
@rm -rf tools/protoc/*/include
+ @echo "Cleaning downloaded UI assets..."
+ @rm -rf ui/node_modules ui/package-lock.json
+ @rm -rf ui/ui/lib
Review Comment:
‼️ **clean-all deletes tracked UI sources**
`ui/ui/lib` now contains tracked source files
(`vermeer/ui/ui/lib/functions.js` and `vermeer/ui/ui/lib/vermeer.css`), but
`make clean-all` removes the whole directory. I verified this on the PR head:
after `make clean-all`, `git status` reports both files as deleted.
Please delete only generated/downloaded assets under `ui/ui/lib`, or
preserve the tracked JS/CSS files when cleaning.
##########
vermeer/Makefile:
##########
@@ -31,8 +31,13 @@ download-binaries:
@echo "Downloading binary dependencies..."
@./scripts/download_binaries.sh || (echo "Failed to download binaries"
&& exit 1)
+# Download UI assets (jQuery, Bootstrap, Glyphicons)
+download-ui-assets:
+ @echo "Downloading UI assets..."
+ @./scripts/download_ui_assets.sh || (echo "Failed to download UI
assets" && exit 1)
Review Comment:
‼️ **Make target cannot execute the new script**
The new script is committed with mode `100644` (`git ls-tree HEAD
vermeer/scripts/download_ui_assets.sh`), but this target executes it directly.
I verified the current head in a clean worktree and `make download-ui-assets`
fails with `/bin/sh: ./scripts/download_ui_assets.sh: Permission denied`, so
`make init`, `make generate-assets`, and the Docker build path that call the
same script directly will fail as well.
Please either commit the script as executable (`chmod +x
vermeer/scripts/download_ui_assets.sh`) or invoke it through `bash`
consistently in every caller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
