VGalaxies commented on PR #3039: URL: https://github.com/apache/hugegraph/pull/3039#issuecomment-4589382474
Non-blocking review comment: `hasUsableMatchIndex()` currently treats only boolean properties with secondary/unique indexes as safe to push down before `match()`. That seems narrower than the predicate set being handled (`gt/gte/lt/lte/neq`) and may stop range-indexed numeric/text predicates from using the backend index. Please add a regression test for an indexed non-boolean range predicate before `match()`, or generalize the index-type check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
