VGalaxies commented on code in PR #2937:
URL: https://github.com/apache/hugegraph/pull/2937#discussion_r3331568650
##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/core/GraphManager.java:
##########
@@ -1557,6 +1551,14 @@ private void loadGraph(String name, String
graphConfPath) {
String raftGroupPeers = this.conf.get(ServerOptions.RAFT_GROUP_PEERS);
config.addProperty(ServerOptions.RAFT_GROUP_PEERS.name(),
raftGroupPeers);
+
+ // Transfer `pd.peers` from server config to graph config
+ // Only inject if not already configured in graph config
+ if (!config.containsKey("pd.peers")) {
+ String pdPeers = this.conf.get(ServerOptions.PD_PEERS);
+ config.addProperty("pd.peers", pdPeers);
Review Comment:
Non-blocking: this now injects server-level `pd.peers` into every graph
config when the graph config does not contain it. Please guard this with a
non-empty/PD-enabled check, or add coverage for standalone RocksDB graphs, so a
default or empty server-level PD setting does not silently change graph startup
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
