Copilot commented on code in PR #354:
URL: https://github.com/apache/hugegraph-ai/pull/354#discussion_r3333203665
##########
hugegraph-llm/src/hugegraph_llm/demo/rag_demo/rag_block.py:
##########
@@ -49,6 +49,7 @@ def rag_answer(
topk_return_results=20,
vector_dis_threshold=0.9,
topk_per_keyword=1,
+ include_trace: bool = False,
) -> Tuple:
Review Comment:
`rag_answer()` can return a dict when `include_trace=True` (see `return
res`), but the function is still annotated as returning `Tuple`. This makes the
public signature misleading for callers and type checking, and it can hide
breaking changes in the demo/app integration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
