dpol1 commented on code in PR #3035:
URL: https://github.com/apache/hugegraph/pull/3035#discussion_r3333421160
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/schema/PropertyKey.java:
##########
@@ -121,7 +121,12 @@ public void defineDefaultValue(Object value) {
public Object defaultValue() {
// TODO add a field default_value
- return this.userdata().get(Userdata.DEFAULT_VALUE);
+ Object value = this.userdata().get(Userdata.DEFAULT_VALUE);
+ // Userdata is reloaded from JSON as a raw Map, so a typed default
+ // value (e.g. Date) comes back as a String. Normalize it to the
+ // runtime type expected by this property key's data type. Idempotent
+ // for values already of the expected type.
+ return value == null ? null : this.validValue(value);
Review Comment:
Good catch, thanks! You're totally right about `convValue()` blindly keeping
the `ArrayList` from the JSON parser.
I've updated both `core` and `struct` to pick the container based on
`this.cardinality` (using a `LinkedHashSet` for SET). I also beefed up the
tests to inject duplicates and verify they actually get collapsed into a `Set`.
Just pushed the fix by 14431b1, let me know if it looks good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
