nw9663644-eng commented on PR #356: URL: https://github.com/apache/hugegraph-ai/pull/356#issuecomment-4594388636
I have covered the requested scope and suggested tests. Current test coverage includes: * TXT file reading regression * DOCX file reading regression * text-based PDF reading * PDF files without extractable text * unreadable PDF behavior * encrypted PDF behavior * unsupported file type behavior The implementation also covers: * adding `pypdf` to `hugegraph-llm/pyproject.toml` * extracting PDF text page by page in stable order * replacing the previous PDF TODO error path * keeping existing TXT and DOCX behavior unchanged * updating the demo upload copy to mention TXT, DOCX, and PDF I also checked the dependency lock situation. The repository did not have an existing `uv.lock` file before running `uv lock`; running it locally generated a new root-level `uv.lock`. To avoid introducing a large new lock file unrelated to this focused change, I did not include it in this PR. The new PDF dependency is added to `hugegraph-llm/pyproject.toml`. Local checks: * `python -m py_compile hugegraph-llm/src/tests/test_vector_index_utils.py` * `python -m py_compile hugegraph-llm/src/hugegraph_llm/utils/vector_index_utils.py` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
