bitflicker64 commented on code in PR #3052: URL: https://github.com/apache/hugegraph/pull/3052#discussion_r3368865458
########## hugegraph-server/Dockerfile: ########## @@ -67,5 +66,9 @@ RUN chmod 755 ./docker-entrypoint.sh EXPOSE 8080 VOLUME /hugegraph-server +HEALTHCHECK --interval=15s --timeout=10s --start-period=90s --retries=3 \ + CMD curl -fsS http://localhost:8080/versions >/dev/null \ + || kill -0 "$(cat ./bin/pid 2>/dev/null)" 2>/dev/null Review Comment: Good point --start-period=90s already covers the startup window, so the || kill -0 fallback is redundant and weakens the signal. Removing it from all four Dockerfiles so the HEALTHCHECK is purely HTTP-based. Pushing now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
