bitflicker64 commented on code in PR #3055:
URL: https://github.com/apache/hugegraph/pull/3055#discussion_r3378104255
##########
.github/workflows/server-ci.yml:
##########
@@ -76,7 +76,15 @@ jobs:
mvn package -Dmaven.test.skip=true -pl
hugegraph-server/hugegraph-dist -am -ntp
VERSION=$(mvn help:evaluate -Dexpression=project.version -q
-DforceStdout)
SERVER_DIR=hugegraph-server/apache-hugegraph-server-$VERSION/
+ set +e
$TRAVIS_DIR/test-start-hugegraph.sh $SERVER_DIR
+ EXIT=$?
+ set -e
+ if [ $EXIT -eq 77 ]; then
+ echo "::notice::Startup tests skipped — required tools not
available"
+ exit 0
Review Comment:
Switched to the preflight/guard pattern as requested. The preflight step
writes can_run and skip_reason to $GITHUB_OUTPUT; the test step is guarded by
if: steps.<id>.outputs.can_run == 'true' so it shows as grey Skipped (not green
Success) when prerequisites are missing. The Store preflight distinguishes
missing tool: <name> from ulimit -n is <N> (store requires >= 1024) with
separate skip_reason values. Pushing now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
