imbajin commented on code in PR #3056:
URL: https://github.com/apache/hugegraph/pull/3056#discussion_r3379421234


##########
hugegraph-server/hugegraph-dist/docker/README.md:
##########
@@ -130,3 +130,20 @@ HUGEGRAPH_VERSION=1.7.0 docker compose -f 
docker-compose-3pd-3store-3server.yml
 
 See [docker/README.md](../../../docker/README.md) for the full setup guide,
 environment variable reference, and troubleshooting.
+
+## 6. Process Supervision & Health Checks
+
+All four HugeGraph Docker images (PD, Store, Server, Server-hstore) include
+native `HEALTHCHECK` instructions. `docker ps` shows real health status:
+
+| Image | Health endpoint |
+|---|---|
+| `hugegraph/hugegraph` | `GET /versions` on port 8080 |
+| `hugegraph/hugegraph-hstore` | `GET /versions` on port 8080 |
+| `hugegraph/hugegraph-pd` | `GET /v1/health` on port 8620 |
+| `hugegraph/hugegraph-store` | `GET /v1/health` on port 8520 |
+
+The entrypoints supervise the Java process directly — when Java exits, the
+container exits and Docker's `restart: unless-stopped` policy brings it back
+automatically. The old cron-based monitor (`-m true`) is for VM/bare-metal

Review Comment:
   ⚠️ **Scope the restart-policy behavior**
   
   Evidence: this says Docker will bring the container back automatically, but 
`restart: unless-stopped` is supplied by the compose files, not by the image or 
entrypoint. A user following the direct `docker run` examples will not get 
automatic restarts unless they also pass a Docker restart policy.
   
   Impact: operators can expect self-recovery that is not actually configured 
for non-compose deployments.
   
   Requested fix: qualify this as applying when the container is started with a 
restart policy, for example the provided compose files use `restart: 
unless-stopped`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to