dpol1 commented on code in PR #3058:
URL: https://github.com/apache/hugegraph/pull/3058#discussion_r3402513184
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/backend/tx/GraphTransaction.java:
##########
@@ -140,8 +139,6 @@ public class GraphTransaction extends IndexableTransaction {
private final int verticesCapacity;
private final int edgesCapacity;
Review Comment:
The removal is intentional and scoped. This PR only drops
`storeEventListenStatus`, mirroring #3017, which already removed the sibling
`graphCacheListenStatus` from this same class (also `protected static final`,
same 1.7.0 vintage) when it moved graph-cache listening to the ref-counted
`GRAPH_CACHE_EVENT_LISTENERS` holder. The `// TODO (follow-up):
storeEventListenStatus has the same owner-first close bug…` comment #3017 left
in `CachedGraphTransaction` scoped exactly this change.
I'd prefer not to keep a deprecated compatibility field:
- It's internal listen-tracking state consumed only by the in-tree
`CachedGraphTransaction`; no external extension point uses it, and #3017
already set the precedent
of removing the equivalent field outright without a shim.
- A `@Deprecated` no-op field can't preserve the old per-graph boolean
semantics (now replaced by ref-counting), so it would be dead, misleading
static state.
The PR description already notes this as an intentional internal-API
removal; I can expand that into an explicit breaking-change/release-note line
if you'd prefer. Does that work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
