imbajin commented on PR #3060:
URL: https://github.com/apache/hugegraph/pull/3060#issuecomment-4758480678
Thanks, the current head looks directionally good and preserves the default
`GET /tasks/{id}` behavior. Could you please add or clarify a bit more
regression coverage before merge?
Two areas seem worth covering:
1. A regression case with a genuinely large/compressed task result,
verifying metadata-only paths such as `GET /tasks`, task restore/scheduler
loops, and `with_result=false` do not load/decompress `task_result`.
2. The distributed task/result delete path: please either make the `~task` +
`~taskresult` cleanup failure-safe/atomic, or add a targeted test/explanation
for the current two-step delete path. Since `TaskTransaction` auto-commits
after `removeTaskVertex()`, a failure between deleting `~taskresult` and
deleting `~task` could otherwise leave a live task whose result has already
been removed.
Minor checklist note: `with_result` is a new query parameter, so the PR
checklist/docs status may need to reflect that public API surface, even if the
runtime OpenAPI annotation already exposes it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
