VGalaxies commented on code in PR #673:
URL:
https://github.com/apache/hugegraph-toolchain/pull/673#discussion_r3469353928
##########
hugegraph-client/src/test/java/org/apache/hugegraph/api/ApiTestSuite.java:
##########
@@ -74,6 +75,7 @@
CountApiTest.class,
RingsRaysApiTest.class,
SameNeighborsApiTest.class,
+ SameNeighborsBatchApiTest.class,
Review Comment:
**Low: Enabled limit coverage reuses a stale request**
`hugegraph-client/src/test/java/org/apache/hugegraph/api/ApiTestSuite.java:78`
**Evidence**
- In `SameNeighborsBatchApiTest.testSameNeighborsWithLimit()`, the later
`limit(2L)` and `limit(1L)` blocks create builders but post the original
request built before those options were applied.
**Impact**
- Even after the endpoint issue is fixed, the suite can pass without
exercising batch limit behavior.
**Requested fix**
- Rebuild and assign the request after setting each block’s options, then
update the `limit(1L)` assertions to expect limited results.
##########
hugegraph-client/src/test/java/org/apache/hugegraph/api/ApiTestSuite.java:
##########
@@ -74,6 +75,7 @@
CountApiTest.class,
RingsRaysApiTest.class,
SameNeighborsApiTest.class,
+ SameNeighborsBatchApiTest.class,
Review Comment:
**High: Enabled test suite calls an unsupported server endpoint**
`hugegraph-client/src/test/java/org/apache/hugegraph/api/ApiTestSuite.java:78`
**Evidence**
- `SameNeighborsBatchAPI.type()` returns `sameneighborsbatch`, so adding
`SameNeighborsBatchApiTest.class` makes `ApiTestSuite` post to
`/traversers/sameneighborsbatch`; the CI workflow runs `ApiTestSuite` against
server commit `8c1ee71`, where only `SameNeighborsAPI` at
`/traversers/sameneighbors` exists.
**Impact**
- `mvn test -Dtest=ApiTestSuite` will fail in CI once this class is included.
**Requested fix**
- Align the client/test with the server route and response contract, or keep
this test excluded until the CI server revision actually provides the batch
endpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
