LRriver commented on PR #361: URL: https://github.com/apache/hugegraph-ai/pull/361#issuecomment-4833384024
Updated in `10524d2` after rebasing `extract_api` onto the latest `origin/main`. Addressed the latest review items: - `/graph/extract` now validates workflow output against the property-graph import contract before returning success. Malformed vertices/edges now fail with `GRAPH_EXTRACT_INVALID_FLOW_OUTPUT`. - `GraphImportRequest` and `Commit2Graph` now share one property value validator. Integer types reject `bool`; `FLOAT`/`DOUBLE` accept JSON numeric `int`/`float` values while rejecting `bool`. - `Commit2Graph.init_schema_if_need()` now uses `useCustomizeStringId()` for `CUSTOMIZE_STRING` vertex labels. - `/graph/import` request-validation errors now return `GRAPH_IMPORT_VALIDATION_ERROR` with `phase=import`. - Added coverage for the default background-worker job route path (`run_jobs_inline=None`). Workflow/type-check signal: - The branch is rebased onto current `origin/main`; `git diff origin/main...HEAD -- .github` is empty, so this PR no longer removes the workflow changes from main. - I ran `uv run --extra dev ty check hugegraph-llm/src hugegraph-python-client/src`; it executes now, but reports the existing repository-wide baseline (`719 diagnostics`) across unrelated files and test fixtures. I did not fold that broad type cleanup into this PR. Local verification: - `uv run ruff format --check .` - `uv run ruff check .` - `SKIP_EXTERNAL_SERVICES=true uv run pytest hugegraph-llm/src/tests/api hugegraph-llm/src/tests/operators -v --tb=short` (`329 passed`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
