imbajin commented on code in PR #3078:
URL: https://github.com/apache/hugegraph/pull/3078#discussion_r3504175859
##########
pom.xml:
##########
@@ -89,10 +89,10 @@
<fabric8.version>5.6.0</fabric8.version>
<revision>1.7.0</revision>
<hugegraph-commons.version>1.7.0</hugegraph-commons.version>
- <lombok.version>1.18.30</lombok.version>
+ <lombok.version>1.18.34</lombok.version>
<release.name>hugegraph</release.name>
- <maven.compiler.source>11</maven.compiler.source>
- <maven.compiler.target>11</maven.compiler.target>
+ <maven.compiler.source>21</maven.compiler.source>
Review Comment:
Blocking: yes. This changes the whole reactor to Java 21 bytecode while
several workflows still run Java 11 matrix legs. Those jobs will invoke Maven
under JDK 11 with source/target 21, which javac 11 cannot compile; either keep
the compiler release/source/target compatible with Java 11, or remove the JDK
11 matrix entries and update the compatibility claim.
##########
hugegraph-server/pom.xml:
##########
@@ -118,6 +118,11 @@
<artifactId>gremlin-core</artifactId>
<version>${tinkerpop.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.tinkerpop</groupId>
+ <artifactId>gremlin-util</artifactId>
Review Comment:
Blocking: yes. Adding gremlin-util and upgrading TinkerPop/Lombok changes
the third-party dependency set, but no install-dist release metadata changed.
The current known-dependencies/LICENSE entries still list TinkerPop 3.5.1 and
Lombok 1.18.24 and have no gremlin-util entry, so refresh known-dependencies
plus LICENSE/NOTICE/licenses before merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
