kjswaruph commented on issue #3090: URL: https://github.com/apache/hugegraph/issues/3090#issuecomment-5042810394
Hey @imbajin as #3096 has been merged here is my proposed plan - Use infoInitializedGraph.remove(this.graphName) in HstoreSessionsimpl.clear() to remove the graph from infoInitializedGraph to fix hstore lifecycle - Update test guard rails to use the assumeFalse instead of assumeTrue so unsupported tests are skipped on HStore - Tests which are not supported by Hstore like Ramtable will be excluded - Replace the fixed Thread.sleep(100) cleanup wait with a stronger check that schema and cache cleanup have actually completed. - Add a Hstore specific codec for operator sinking so property metadata is decoded consistently. Fixing this mismatch should make the supported OLAP,scan, etc tests pass without changing RocksDB binary format Please review and let me know if this plan is good to proceed or if you like to add any changes or improvements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
