bitflicker64 commented on PR #3105: URL: https://github.com/apache/hugegraph/pull/3105#issuecomment-5078236824
All three 5.5/10 items addressed in `1f3f01e`: 1. **netstat -an empty output** — `[[ -n "$out" ]]` guard added. Empty/diagnostic-only output now falls through to /dev/tcp instead of reporting `port_checked=1`. 2. **No watchdog test** — extracted inline watchdog into `run_with_deadline()` helper (positional params, no injection). Added deterministic test: `run_with_deadline "sleep 5" 2` asserts completion in ≤3s. Proves the watchdog actually kills a stuck child. 3. **EXIT trap cleanup** — already addressed in the current head. The trap at line 340 includes `kill -9 $PY_PID; wait $PY_PID` so the Python listener is reaped even when `check_port` calls `exit 1`. Also fixed a regression from authority parsing: invalid ports like `http://127.0.0.1:abc` were silently falling through to default port 80 instead of being rejected. Added a guard that rejects authority with exactly one colon and no valid numeric port. 35/35 tests pass. Re-requesting review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
