bitflicker64 commented on PR #3119: URL: https://github.com/apache/hugegraph/pull/3119#issuecomment-5101831223
Did a self-review pass over the whole diff and pushed 090763a6 with the follow-ups, no behaviour change beyond the two fixes below: - `get_prop` now uses `sed -E` rather than `-r`, which only GNU sed documents. - The gremlin-server.yaml block is no longer appended onto a last line that has no trailing newline. The rest is text and hygiene: the option description, the `InitStore` comment and `docker/README.md` still said every `auth.authenticator` needs the built-in admin account, which stopped being true when the check was narrowed; `InitStoreConfigTest` is now imported in suite order. Since the entrypoint reapplies what `bin/enable-auth.sh` does when it cannot run the script itself, there is now a test asserting the entrypoint still names every class and key that script does, so the two cannot drift silently. Happy to move that logic into `enable-auth.sh` instead if you would rather have one source of truth there, it just reaches outside the docker path. Local run: 106 assertions across 30 entrypoint cases, unit suite 626 tests green on JDK 11, rat and editorconfig clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
