bitflicker64 commented on code in PR #3105:
URL: https://github.com/apache/hugegraph/pull/3105#discussion_r3664128766
##########
.github/workflows/server-ci.yml:
##########
@@ -70,17 +70,30 @@ jobs:
run: |
mvn clean compile -U -Dmaven.javadoc.skip=true -ntp
+ - name: Run check_port unit tests
+ if: ${{ env.BACKEND == 'rocksdb' }}
+ run: |
+ # Validates ss/netstat//dev/tcp replacement for lsof
Review Comment:
Right, `/dev/tcp` is left over from an earlier revision that had a
bounded-connect fallback; that branch was removed and the comments were not.
Fixed in `d93b6f9d`, all three sites:
```
-# Validates ss/netstat//dev/tcp replacement for lsof
+# Validates the ss/netstat port preflight that replaced lsof
-# Note: lsof removed from prerequisites (replaced with ss/netstat//dev/tcp
in check_port).
+# Note: lsof removed from prerequisites; check_port now uses ss, falling
back
+# to netstat, and warns without blocking when neither can answer.
```
`grep -rn "dev/tcp"` over the tree is now empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
